Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2574#discussion_r81303450
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -283,10 +296,16 @@ public void
commitSpecificOffsetsToKafka(Map<KafkaTopicPartition, Long> offsets)
}
}
- if (this.consumer != null) {
- synchronized (consumerLock) {
- this.consumer.commitSync(offsetsToCommit);
- }
+ if (commitInProgress) {
+ LOG.warn("Committing offsets to Kafka takes longer than
the checkpoint interval. " +
+ "Some checkpoints may be subsumed
before committed. " +
+ "This does not compromise Flink's
checkpoint integrity.");
+ }
--- End diff --
Also, in both cases, you cannot know whether it is dropped - it may still
be that only one commit was delayed and the "toCommit" data will actually be
picked up, but with a delay.
I have an idea though where we can check that properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
