Zakelly commented on code in PR #21362:
URL: https://github.com/apache/flink/pull/21362#discussion_r1033205960
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java:
##########
@@ -72,6 +73,10 @@ public void setCurrentKey(@Nonnull K currentKey) {
@Override
public void setCurrentKeyGroupIndex(int currentKeyGroupIndex) {
+ if (!keyGroupRange.contains(currentKeyGroupIndex)) {
+ throw KeyGroupRangeOffsets.newIllegalKeyGroupException(
+ currentKeyGroupIndex, keyGroupRange);
+ }
Review Comment:
> I'm afraid that we cannot avoid the check on accessing state as users
might provide a non-deterministic hashCode for the current key.
Hi @Myasuka , I checked the code in ```StateTable```, and it seems that in
most state accessing cases (except for queryable state) we are checking the key
group from ```keyContext.getCurrentKeyGroupIndex()``` instead of calculating it
by ```hashCode``` of the partitioned key. So actually we are checking the same
value when ```setCurrentKeyGroupIndex``` or state accessing, whether the
hashCode implementation is deterministic or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
