dianfu commented on code in PR #21332:
URL: https://github.com/apache/flink/pull/21332#discussion_r1030214339


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/python/PythonAggregateFunction.java:
##########
@@ -120,6 +163,15 @@ public TypeInference getTypeInference(DataTypeFactory 
typeFactory) {
         if (inputTypes != null) {
             builder.typedArguments(inputTypes);
         }
+
+        if (resultType == null) {

Review Comment:
   What about moving this to the constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to