reta commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1030438140
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSink.java:
##########
@@ -88,4 +88,8 @@ public SinkWriter<IN> createWriter(InitContext context)
throws IOException {
context.metricGroup(),
context.getMailboxExecutor());
}
+
+ DeliveryGuarantee getDeliveryGuarantee() {
Review Comment:
I have never understood the idea of `@VisibleForTesting` to workaround Java
visibility rules, hopefully it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
