JingsongLi commented on code in PR #388:
URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027638918
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -130,4 +119,42 @@ public SplitEnumerator<FileStoreSourceSplit,
PendingSplitsCheckpoint> restoreEnu
return new StaticFileStoreSplitEnumerator(context, snapshot,
splits);
}
}
+
+ private DataFilePlan batchScanSplits(DataTableScan scan) {
+ return scan.plan();
+ }
+
+ private DataFilePlan continuousFirstScanSplits(
+ DataTableScan scan, SnapshotManager snapshotManager) {
+ switch (startupMode) {
Review Comment:
I think we can extract this logical to `SnapshotEnumerator.startup`.
We don't need to introduce `DataFilePlanBuilder`, it is just a simple call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
