reta commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1026434221
##########
pom.xml:
##########
@@ -327,6 +327,12 @@ under the License.
</dependency>
<!-- For dependency convergence -->
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
Review Comment:
OK, now I got your question, I was confused by the location of this comment
(in `pom.xml`), so if we look at the JNA for SQL jar, there are 2 pieces there:
1. Exclusions of the bootstrap classes:
https://github.com/apache/flink-connector-opensearch/pull/1/files#diff-01d20faddfa10d1695142e0f51f1c3ec81396425359ab688cbc8078a3cdb8712R83
(they are not needed on the client at all)
2. Because only bootstrap classes used JNA, this dependency is also
excluded:
https://github.com/apache/flink-connector-opensearch/pull/1/files#diff-01d20faddfa10d1695142e0f51f1c3ec81396425359ab688cbc8078a3cdb8712R67
Does it answer your question?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
