zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1026411856
##########
pom.xml:
##########
@@ -327,6 +327,12 @@ under the License.
</dependency>
<!-- For dependency convergence -->
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
Review Comment:
The sql-jar is supposed to bundle all dependencies required to interface
with opensearch. This commonly (but not always!) means to bundled all
transitive dependencies of whatever opensearch dependencies it has.
One of these transitive dependencies is jna, which is not bundled in the sql
jar.
The question is, why isn't that bundled? Is it an optional thing? Is there a
licensing issue that requires the user to provide it at runtime? Is it just not
required for talking to opensearch?
If it isn't required for our use-case, then we may be able to just exclude
it instead of having to worry about converging dependencies and keeping it
compatible with opensearch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
