[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

[GitBox]

JingsongLi commented on code in PR #388:
URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1026088012


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FlinkSourceBuilder.java:
##########
@@ -150,20 +153,20 @@ private FileStoreSource buildFileSource(boolean 
isContinuous, boolean continuous
 
             LogStartupMode startupMode = conf.get(LOG_SCAN);
             if (logSourceProvider == null) {
-                return buildFileSource(true, startupMode == 
LogStartupMode.LATEST);
+                return buildFileSource(true, startupMode, 
conf.get(LOG_SCAN_TIMESTAMP_MILLS));

Review Comment:
   > Shall we also consider changelog produced by file store as log?
   
   Yes.
   
   We have been using `log` on incremental reading of files, such as `log.scan` 
for full and latest.
   
   You can think log as changelog. It is not just for kafka.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org