[GitHub] [flink] 1996fanrui commented on a diff in pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

[GitBox]

1996fanrui commented on code in PR #21281:
URL: https://github.com/apache/flink/pull/21281#discussion_r1023807792


##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java:
##########
@@ -204,7 +204,8 @@ private void checkFailureAgainstCounter(
             if (continuousFailureCounter.get() > tolerableCpFailureNumber) {
                 clearCount();
                 errorHandler.accept(
-                        new 
FlinkRuntimeException(EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE));
+                        new FlinkRuntimeException(
+                                EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE, 
exception));

Review Comment:
   How about this? We tell user the latest checkpoint failed cause and how to 
check full checkpoint info?
   
   The `exception.getCheckpointFailureReason().message()` is a short 
description.
   
   ```
   public static final String EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE =
               "Exceeded checkpoint tolerable failure threshold, the latest 
checkpoint failed due to %s,"
                       + " view the Checkpoint History tab or the Job Manager 
log to find out why"
                       + " continuous checkpoints failed.";
   
   new FlinkRuntimeException(String.format(
           EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE,
           exception.getCheckpointFailureReason().message()));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org