zentol commented on code in PR #21304:
URL: https://github.com/apache/flink/pull/21304#discussion_r1021377774
##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/ContextClassLoadingSettingTest.java:
##########
@@ -157,22 +161,26 @@ void
testAkkaRpcService_ScheduleRunnableWithFixedRateSetsFlinkContextClassLoader
contextClassLoaders.add(
Thread.currentThread().getContextClassLoader());
} else {
- throw new RuntimeException("cancel task");
+ terminalFuture.complete(null);
Review Comment:
You should still throw an exception such that the scheduled action stops
early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
