[
https://issues.apache.org/jira/browse/FLINK-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529577#comment-15529577
]
Ted Yu commented on FLINK-4701:
-------------------------------
How about other threads which may modify cancelables ?
> Unprotected access to cancelables in StreamTask
> -----------------------------------------------
>
> Key: FLINK-4701
> URL: https://issues.apache.org/jira/browse/FLINK-4701
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In performCheckpoint():
> {code}
> AsyncCheckpointRunnable
> asyncCheckpointRunnable = new AsyncCheckpointRunnable(
> "checkpoint-" + checkpointId
> + "-" + timestamp,
> this,
> cancelables,
> chainedStateHandles,
> keyGroupsStateHandleFuture,
> checkpointId,
> bytesBufferedAlignment,
> alignmentDurationNanos,
> syncDurationMillis,
> endOfSyncPart);
> synchronized (cancelables) {
>
> cancelables.add(asyncCheckpointRunnable);
> }
> {code}
> Construction of AsyncCheckpointRunnable should be put under the synchronized
> block of cancelables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
