Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2556#discussion_r80885273
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
---
@@ -210,7 +210,17 @@ public void onSuccess(Object filePathOption) throws
Throwable {
LOG.error("Displaying
TaskManager log failed.", e);
return;
}
- long fileLength = raf.length();
+ long fileLength;
+ try {
+ fileLength =
raf.length();
+ } catch (IOException ioe) {
+ display(ctx, request,
"Displaying TaskManager log failed.");
+ LOG.error("Displaying
TaskManager log failed.", ioe);
+ if (raf != null) {
+ raf.close();
+ }
+ return;
--- End diff --
let's just re-throw the exception to retain current behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
