[
https://issues.apache.org/jira/browse/FLINK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529018#comment-15529018
]
ASF GitHub Bot commented on FLINK-4657:
---------------------------------------
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2550#discussion_r80874290
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -467,6 +487,128 @@ public void registerAtResourceManager(final String
address) {
//TODO:: register at the RM
}
+ @RpcMethod
+ public NextInputSplit requestNextInputSplit(final JobVertexID vertexID,
final ExecutionAttemptID executionAttempt) {
--- End diff --
Thanks for your comments @tillrohrmann . It all sounds reasonable to me.
Limit the rpc error within one specified Exception is a good idea, thus user
can easily know what went wrong.
One minor suggestion, may be we should create a base class `RpcException`,
and make something like `RpcConnectionException`, `RpcExecutionException` and
`RpcTimeoutException` to inherit from that, to make a better more clear. This
can be done in another jira, though.
> Implement HighAvailabilityServices based on zookeeper
> -----------------------------------------------------
>
> Key: FLINK-4657
> URL: https://issues.apache.org/jira/browse/FLINK-4657
> Project: Flink
> Issue Type: New Feature
> Components: Cluster Management
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> For flip-6, we will have ResourceManager and every JobManager as potential
> leader contender and retriever. We should separate them by using different
> zookeeper path.
> For example, the path could be /leader/resource-manaeger for RM. And for each
> JM, the path could be /leader/job-managers/JobID
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
