Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2550#discussion_r80874290
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -467,6 +487,128 @@ public void registerAtResourceManager(final String
address) {
//TODO:: register at the RM
}
+ @RpcMethod
+ public NextInputSplit requestNextInputSplit(final JobVertexID vertexID,
final ExecutionAttemptID executionAttempt) {
--- End diff --
Thanks for your comments @tillrohrmann . It all sounds reasonable to me.
Limit the rpc error within one specified Exception is a good idea, thus user
can easily know what went wrong.
One minor suggestion, may be we should create a base class `RpcException`,
and make something like `RpcConnectionException`, `RpcExecutionException` and
`RpcTimeoutException` to inherit from that, to make a better more clear. This
can be done in another jira, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
