Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2541#discussion_r80730795
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
 ---
    @@ -124,7 +125,7 @@ class StreamExecutionEnvironment(javaEnv: JavaEnv) {
        * Gets the checkpoint config, which defines values like checkpoint 
interval, delay between
        * checkpoints, etc.
        */
    -  def getCheckpointConfig = javaEnv.getCheckpointConfig()
    --- End diff --
    
    Calling Java methods with parenthesis or without actually somewhat subject 
to debate.
    
    For Scala methods, the writer decides whether it is a method with or 
without parenthesis.
    For Java, the caller can only "guess" what the method does (is returning a 
mutable field considered a side effect?), so in most places we call Java 
methods as Java methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to