nirtsruya commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r1009255994
########## flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbWriteRequest.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.dynamodb.sink; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.util.Preconditions; + +import software.amazon.awssdk.services.dynamodb.model.AttributeValue; + +import java.io.Serializable; +import java.util.Map; +import java.util.Objects; + +/** + * Represents a single Write Request to DynamoDb. Contains the item to be written as well as the + * type of the Write Request (PUT/DELETE) + */ +@PublicEvolving +public class DynamoDbWriteRequest implements Serializable { + + private final Map<String, AttributeValue> item; + private final DynamoDbWriteRequestType type; + + private DynamoDbWriteRequest(Map<String, AttributeValue> item, DynamoDbWriteRequestType type) { + this.item = item; + this.type = type; + } + + public Map<String, AttributeValue> getItem() { + return item; + } + + public DynamoDbWriteRequestType getType() { + return type; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + DynamoDbWriteRequest that = (DynamoDbWriteRequest) o; + return item.equals(that.item) && type == that.type; + } + + @Override + public int hashCode() { + return Objects.hash(item, type); + } Review Comment: There is this method however that is used for the sink state serializing - [AsyncSinkWriterTestUtils](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTestUtils.java#L46). It relies on equals I think. but if it is not required to use it I can reimplement it in our test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
