zentol commented on code in PR #21128:
URL: https://github.com/apache/flink/pull/21128#discussion_r1009196104
##########
flink-end-to-end-tests/flink-end-to-end-tests-sql/pom.xml:
##########
@@ -154,10 +162,30 @@
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
indentation
##########
flink-end-to-end-tests/flink-end-to-end-tests-sql/pom.xml:
##########
@@ -115,6 +115,14 @@
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
indentation
##########
flink-connectors/flink-connector-hive/pom.xml:
##########
@@ -1099,33 +1007,8 @@ under the License.
<properties>
<hive.version>3.1.3</hive.version>
<derby.version>10.14.1.0</derby.version>
- <!-- need a hadoop version that fixes
HADOOP-14683 -->
-
<hivemetastore.hadoop.version>2.8.2</hivemetastore.hadoop.version>
Review Comment:
If we're removing all references to this property then we should also remove
it from the root pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
