lindong28 commented on code in PR #163:
URL: https://github.com/apache/flink-ml/pull/163#discussion_r997598885
##########
flink-ml-python/pyflink/ml/core/wrapper.py:
##########
@@ -22,16 +22,15 @@
from pyflink.common import typeinfo, Time
from pyflink.common.typeinfo import _from_java_type, TypeInformation,
_is_instance_of
from pyflink.java_gateway import get_gateway
-from pyflink.table import Table, StreamTableEnvironment
-from pyflink.util.java_utils import to_jarray
-
from pyflink.ml.core.api import Model, Transformer, AlgoOperator, Stage,
Estimator
from pyflink.ml.core.linalg import DenseVectorTypeInfo, SparseVectorTypeInfo,
DenseMatrixTypeInfo, \
VectorTypeInfo, DenseVector
from pyflink.ml.core.param import Param, WithParams, StringArrayParam,
IntArrayParam, VectorParam, \
FloatArrayParam, FloatArrayArrayParam, WindowsParam
from pyflink.ml.core.windows import GlobalWindows, CountTumblingWindows,
EventTimeTumblingWindows, \
ProcessingTimeTumblingWindows, EventTimeSessionWindows,
ProcessingTimeSessionWindows
+from pyflink.table import Table, StreamTableEnvironment, Expression
Review Comment:
Can we avoid unnecessary movement of import statements?
##########
flink-ml-python/pyflink/examples/ml/arraytovector_example.py:
##########
@@ -0,0 +1,60 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+# Simple program that converts double arrays to vectors.
Review Comment:
nits: Would it be more informative and consistent with `double arrays` to
specify the type of vectors like below:
vectors -> dense vectors
Same for other occurrences of this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
