masteryhx commented on code in PR #21053:
URL: https://github.com/apache/flink/pull/21053#discussion_r996601693
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java:
##########
@@ -39,6 +41,15 @@ public interface CompletedCheckpointStore {
* <p>Only a bounded number of checkpoints is kept. When exceeding the
maximum number of
* retained checkpoints, the oldest one will be discarded.
*
+ * <p>After <a
href="https://issues.apache.org/jira/browse/FLINK-24611";>FLINK-24611</a>, {@link
+ * SharedStateRegistry#unregisterUnusedState} should be called here to
subsume unused state.
+ * <font color="#FF0000"><strong>Note</strong></font>, the {@link
CompletedCheckpoint} passed to
+ * SharedStateRegistry must be the same object as the input parameter,
otherwise the state may
Review Comment:
IIUC, the fallible place is SharedStateRegistryFactory#create where the same
object should be passed.
So maybe specify it here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
