sap1ens commented on code in PR #20475:
URL: https://github.com/apache/flink/pull/20475#discussion_r996570099


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -398,6 +407,11 @@ private void registerMetricSync() {
                 });
     }
 
+    private String createProducerClientId(Properties props, int subtaskId) {
+        String prefix = 
props.getProperty(KafkaSinkOptions.CLIENT_ID_PREFIX.key());
+        return prefix + "-" + subtaskId;

Review Comment:
   @mas-chen thanks for the suggestion! It doesn't look like it's easy to 
access a subtask id from the `KafkaCommitter`... Would you recommend using 
something like a `producerId` or `transactionId` instead? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to