sap1ens commented on code in PR #403:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/403#discussion_r996346689
##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/decorators/CmdStandaloneJobManagerDecorator.java:
##########
@@ -80,9 +80,14 @@ private List<String> getApplicationClusterArgs() {
}
Boolean allowNonRestoredState =
kubernetesJobManagerParameters.getAllowNonRestoredState();
- if (allowNonRestoredState != null) {
+ if (allowNonRestoredState != null && allowNonRestoredState) {
args.add("--allowNonRestoredState");
- args.add(allowNonRestoredState.toString());
+ }
+
+ String savepointPath =
kubernetesJobManagerParameters.getSavepointPath();
+ if (savepointPath != null) {
+ args.add("--fromSavepoint");
+ args.add(savepointPath);
Review Comment:
Yep, I think you're right: it seems like just fixing the
`allowNonRestoredState` flag would be enough.
However, I think it's logical to provide the two options together via the
command-line. They always come together (check `SavepointConfigOptions`,
`SavepointRestoreSettings`, etc.) and I was really surprised when I didn't see
the `fromSavepoint` argument when debugging.
But if you insist on making the smallest change in this PR then I'll revert
the `fromSavepoint` part. Let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
