[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516424#comment-15516424 ]
ASF GitHub Bot commented on FLINK-4564: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2517#discussion_r80240342 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java --- @@ -163,7 +170,16 @@ public void startQueryService(ActorSystem actorSystem) { } public char getDelimiter() { - return this.delimiter; + return this.globalDelimiter; + } + + public char getDelimiter(int reporterIndex) { + try { + return delimiters.get(reporterIndex); + }catch (IndexOutOfBoundsException e){ + LOG.warn("Delimiter for index {} not found return global delimiter",reporterIndex); --- End diff -- missing space after comma. Message should be "Delimiter for index {} not found, returning global delimiter." > [metrics] Delimiter should be configured per reporter > ----------------------------------------------------- > > Key: FLINK-4564 > URL: https://issues.apache.org/jira/browse/FLINK-4564 > Project: Flink > Issue Type: Bug > Components: Metrics > Affects Versions: 1.1.0 > Reporter: Chesnay Schepler > Assignee: Anton Mushin > > Currently, the delimiter used or the scope string is based on a configuration > setting shared by all reporters. However, different reporters may have > different requirements in regards to the delimiter, as such we should allow > reporters to use a different delimiter. > We can keep the current setting as a global setting that is used if no > specific setting was set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)