JingsongLi commented on code in PR #305:
URL: https://github.com/apache/flink-table-store/pull/305#discussion_r990578854
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWrite.java:
##########
@@ -52,4 +56,35 @@ RecordWriter<T> createEmptyWriter(
*/
Callable<CompactResult> createCompactWriter(
BinaryRowData partition, int bucket, @Nullable List<DataFileMeta>
compactFiles);
+
+ /**
+ * If overwrite is true, the writer will overwrite the store, otherwise it
won't.
+ *
+ * @param overwrite the overwrite flag
+ */
+ void withOverwrite(boolean overwrite);
+
+ /**
+ * Write the record to the store.
+ *
+ * @param record the given record
+ * @throws Exception the thrown exception when writing the record
+ */
+ void write(SinkRecord record) throws Exception;
Review Comment:
`SinkRecord` is a class in `table` instead of file store.
Can we just introduce a `write(BinaryRowData partition, int bucket, T t)`
to this?
`WriteFunction` can be hold in `TableWriteImpl` instead of
`AbstractFileStoreWrite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
