gyfora commented on code in PR #377:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/377#discussion_r980894278
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -426,4 +431,17 @@ protected boolean flinkVersionChanged(SPEC oldSpec, SPEC
newSpec) {
}
return false;
}
+
+ private void setOwnerReference(CR owner, Configuration deployConfig) {
+ final Map<String, String> ownerReference =
+ Map.of(
+ "apiVersion", owner.getApiVersion(),
+ "kind", owner.getKind(),
+ "name", owner.getMetadata().getName(),
+ "uid", owner.getMetadata().getUid(),
+ "blockOwnerDeletion", "false",
+ "controller", "false");
+ deployConfig.set(
+ KubernetesConfigOptions.JOB_MANAGER_OWNER_REFERENCE,
List.of(ownerReference));
+ }
Review Comment:
We could probably change the information passed to getDeployConfig if
necessary. Pass the whole CR + spec instead of meta + spec
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -426,4 +431,17 @@ protected boolean flinkVersionChanged(SPEC oldSpec, SPEC
newSpec) {
}
return false;
}
+
+ private void setOwnerReference(CR owner, Configuration deployConfig) {
+ final Map<String, String> ownerReference =
+ Map.of(
+ "apiVersion", owner.getApiVersion(),
+ "kind", owner.getKind(),
+ "name", owner.getMetadata().getName(),
+ "uid", owner.getMetadata().getUid(),
+ "blockOwnerDeletion", "false",
+ "controller", "false");
+ deployConfig.set(
+ KubernetesConfigOptions.JOB_MANAGER_OWNER_REFERENCE,
List.of(ownerReference));
+ }
Review Comment:
but I dont have a better idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
