[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #370: [FLINK-29288] Make it possible to use job jars in the system classpath

[GitBox]

gyfora commented on code in PR #370:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/370#discussion_r977587900


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -180,10 +180,6 @@ private Optional<String> validateJobSpec(
             return Optional.empty();
         }
 
-        if (StringUtils.isNullOrWhitespaceOnly(job.getJarURI())) {
-            return Optional.of("Jar URI must be defined");
-        }

Review Comment:
   For me your code change seemed to work with the following base image:
   
   ```
   FROM flink:1.15.1
   RUN cp /opt/flink/examples/streaming/StateMachineExample.jar /opt/flink/lib/.
   ```
   
   SessionJob:
   ```
   apiVersion: flink.apache.org/v1beta1
   kind: FlinkSessionJob
   metadata:
     name: basic-session-job-only-example
   spec:
     deploymentName: basic-session-deployment-only-example
     job:
       parallelism: 4
       upgradeMode: stateless
       entryClass: 
org.apache.flink.streaming.examples.statemachine.StateMachineExample
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org