csviri commented on code in PR #362:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/362#discussion_r974124231
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java:
##########
@@ -113,6 +113,9 @@ private void
overrideOperatorConfigs(ConfigurationServiceOverrider overrider) {
} else {
LOG.info("Configuring operator with {} reconciliation threads.",
parallelism);
overrider.withConcurrentReconciliationThreads(parallelism);
+ // feat: separate executor service for workflow
+ // https://github.com/java-operator-sdk/java-operator-sdk/pull/1371
+
overrider.withExecutorService(Executors.newFixedThreadPool(parallelism));
Review Comment:
normally only ` overrider.withConcurrentReconciliationThreads(parallelism);`
if you don't want to replace the executor service with a different flavor (thus
other than a fixed thread pool).
see:
https://github.com/java-operator-sdk/java-operator-sdk/blob/d9e869c3bf5319163d8d884529f6b4a926bd2d85/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java#L127-L129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
