[ 
https://issues.apache.org/jira/browse/FLINK-29261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606342#comment-17606342
 ] 

Gyula Fora commented on FLINK-29261:
------------------------------------

I think this would be a reasonable improvement as the correct json properties 
are already verified and guaranteed by Kubernetes itself based on the installed 
CRD. This would give us a chance to handle multiple versions flexibly

> Consider using FAIL_ON_UNKNOWN_PROPERTIES=false in the Operator
> ---------------------------------------------------------------
>
>                 Key: FLINK-29261
>                 URL: https://issues.apache.org/jira/browse/FLINK-29261
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Matyas Orhidi
>            Priority: Major
>
> The operator cannot be downgraded, once the CR specification is written to 
> the `status`
>  
> Caused by: com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: 
> Unrecognized field "mode" (class 
> org.apache.flink.kubernetes.operator.crd.spec.FlinkDeploymentSpec), not 
> marked as ignorable (12 known properties: "restartNonce", "imagePullPolicy", 
> "ingress", "flinkConfiguration", "serviceAccount", "image", "job", 
> "podTemplate", "jobManager", "logConfiguration", "flinkVersion", 
> "taskManager"])
>  at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: 
> org.apache.flink.kubernetes.operator.crd.spec.FlinkDeploymentSpec["mode"])
> at 
> com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61)
> at 
> com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1127)
> at 
> com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:1989)
> at 
> com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1700)
> at 
> com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1678)
> at 
> com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:319)
> at 
> com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:176)
> at 
> com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:322)
> at 
> com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:4650)
> at 
> com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2831)
> at 
> com.fasterxml.jackson.databind.ObjectMapper.treeToValue(ObjectMapper.java:3295)
> at 
> org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils.deserializeSpecWithMeta(ReconciliationUtils.java:288)
> ... 18 more



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to