sethsaperstein-lyft opened a new pull request, #20843: URL: https://github.com/apache/flink/pull/20843
## What is the purpose of the change This pull request updates the global watermark for subtasks marked idle, rather than waiting until the subtask is no longer idle. That way we avoid a deadlock state where the subtask is idle and unable to emit records due to lookahead. ## Brief change log - The WatermarkSyncCallback is now able to get the global watermark without updating it - Additional debug logging while emitting the watermark ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: [https://flink.apache.org/contributing/code-style-and-quality-common.html#testing](https://flink.apache.org/contributing/code-style-and-quality-common.html#testing) This change added tests and can be verified as follows: - Updated tests to add getWatermark without modifying to watermark - Manually verified the change by running a 8 node cluster with 2 JobManagers and 8 TaskManagers. I manually introduced a sleep of the ShardConsumer thread for 10 minutes for subtask 0 after 5 minutes had passed. This forced the subtask into an idle state as the subtask was no longer receiving data from Kinesis. I verified the local and global watermarks were updated correctly via logs and metrics. When the subtask's ShardConsumer thread continued after the 10 minute sleep, it continued updating the global watermark as usual. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
