zjuwangg commented on code in PR #20542:
URL: https://github.com/apache/flink/pull/20542#discussion_r971943575
##########
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/HBaseSinkFunction.java:
##########
@@ -191,8 +195,10 @@ private void checkErrorAndRethrow() {
public void invoke(T value, Context context) throws Exception {
checkErrorAndRethrow();
- mutator.mutate(mutationConverter.convertToMutation(value));
-
+ Mutation mutation = mutationConverter.convertToMutation(value);
+ synchronized (mutationMap) {
+ mutationMap.put(mutation.getRow(), mutation);
Review Comment:
In this way, all mutations with the same rowkey value will only remain the
last one.
But `mutationConverter` behavior is not controlled, which means such
mutations as following list will casuse data quaility problem.
-D (rk1, f1:v1)
+I (rk1, f2:v2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
