zentol commented on code in PR #37:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/37#discussion_r971912006


##########
pom.xml:
##########
@@ -51,6 +51,15 @@ under the License.
                </developerConnection>
        </scm>
 
+       <pluginRepositories>
+               <pluginRepository>
+                       <!-- Allows exec-maven-plugin to resolve snapshot 
plugin dependencies -->

Review Comment:
   Basically, plugins set on the dependency are only looked up in specific 
repositories, and apparently not in those that we have configured :shrug: 



##########
pom.xml:
##########
@@ -753,6 +762,35 @@ under the License.
                                <extensions>true</extensions>
                        </plugin>
 
+                       <plugin>
+                               <groupId>org.codehaus.mojo</groupId>
+                               <artifactId>exec-maven-plugin</artifactId>
+                               <version>3.1.0</version>
+                               <inherited>false</inherited>

Review Comment:
   We dont want to run this multiple times. The checker is not written to only 
consider part of the project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to