Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2330#discussion_r79791053
--- Diff:
flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -67,18 +66,23 @@
protected abstract T mapResultToTuple(Result r);
--- End diff --
Can we remove the confusing comment `"abstract methods allow for multiple
table and scanners in the same job"` and add JavaDocs to all abstract methods
that describe what is expected from their implementation?
A `TableInputFormat` instance should only scan a single table. In case more
tables need to be read, each could be read with a separate `TableInputFormat`
instance and the output of those could be unioned if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
