pvary commented on code in PR #366:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/366#discussion_r969157975
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/listener/FlinkResourceListenerTest.java:
##########
@@ -58,36 +58,40 @@ public void testListeners() {
var eventRecorder = EventRecorder.create(kubernetesClient, listeners);
var deployment = TestUtils.buildApplicationCluster();
- statusRecorder.updateStatusFromCache(deployment);
- statusRecorder.patchAndCacheStatus(deployment);
assertTrue(listener1.updates.isEmpty());
assertTrue(listener2.updates.isEmpty());
assertTrue(listener1.events.isEmpty());
assertTrue(listener2.events.isEmpty());
-
deployment.getStatus().setJobManagerDeploymentStatus(JobManagerDeploymentStatus.ERROR);
-
- statusRecorder.patchAndCacheStatus(deployment);
+ statusRecorder.updateStatusFromCache(deployment);
+ assertEquals(1, listener1.updates.size());
+ statusRecorder.updateStatusFromCache(deployment);
assertEquals(1, listener1.updates.size());
assertEquals(deployment, listener1.updates.get(0).getFlinkResource());
- assertEquals(1, listener2.updates.size());
Review Comment:
Did we intentionally remove the checks against `listener2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
