JingsongLi commented on code in PR #291:
URL: https://github.com/apache/flink-table-store/pull/291#discussion_r969135349
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/memory/MemoryPoolFactory.java:
##########
@@ -78,20 +85,27 @@ public int pageSize() {
@Override
public void returnAll(List<MemorySegment> memory) {
+ allocatedPages -= memory.size();
innerPool.returnAll(memory);
}
@Override
public int freePages() {
- return innerPool.freePages();
+ // Actually, other owners still keep 1 page
+ // TODO We need to optimize this one page later.
Review Comment:
Track this in: https://issues.apache.org/jira/browse/FLINK-29276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
