reswqa commented on code in PR #20796: URL: https://github.com/apache/flink/pull/20796#discussion_r969078333
########## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFileDataManagerTest.java: ########## @@ -340,6 +341,57 @@ void testRegisterSubpartitionReaderAfterReleased() { .hasMessageContaining("HsFileDataManager is already released."); } + /** + * When the result partition fails, the view lock may be obtained when the FileDataManager lock + * is held. In the same time, the downstream thread will acquire the lock of the FileDataManager + * when acquiring the view lock. To avoid this deadlock, the logical of subpartition view + * release subpartition reader and subpartition reader fail should not be inside lock. + */ + @Test + void testDeadLock() throws Exception { Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org