mxm commented on code in PR #20485:
URL: https://github.com/apache/flink/pull/20485#discussion_r966251899
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/split/PulsarPartitionSplitReaderBase.java:
##########
@@ -179,6 +180,21 @@ public void
handleSplitsChanges(SplitsChange<PulsarPartitionSplit> splitsChanges
this.pulsarConsumer = consumer;
}
+ @Override
+ public void pauseOrResumeSplits(
+ Collection<PulsarPartitionSplit> splitsToPause,
+ Collection<PulsarPartitionSplit> splitsToResume) {
+ if (splitsToPause.size() > 1 || splitsToResume.size() > 1) {
+ throw new IllegalStateException("This pulsar split reader only
support one split.");
Review Comment:
Yes, Pulsar splits are always started in a separate fetcher thread. We still
want to be able to pause these split threads. So the code makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
