gaborgsomogyi commented on code in PR #18118:
URL: https://github.com/apache/flink/pull/18118#discussion_r965767231
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -155,6 +157,134 @@ public void testJoinsCorrectlyWithMultipleKeys() throws
Exception {
"(key2,5):(key2,5)");
}
+ @Test
+ public void testIntervalJoinSideOutputLeftLateData() throws Exception {
Review Comment:
It would be better to have a private function which is called from 2
different tests in order not to mix-up left and right functionality but I'm
personally fine w/ the actual code stand. It's a little bit harder to
understand what's going on inside this single test but not horror.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
