[ 
https://issues.apache.org/jira/browse/FLINK-29227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601631#comment-17601631
 ] 

jackylau edited comment on FLINK-29227 at 9/8/22 6:12 AM:
----------------------------------------------------------

hi [~chesnay]  [~tiwalter]  so i I propose to  add  disruptor to lib, whay do 
you think?

 

<groupId>com.lmax</groupId>
<artifactId>disruptor</artifactId>


was (Author: jackylau):
hi [~tiwalter]  so i I propose to  add  disruptor to lib, whay do you think?

 

<groupId>com.lmax</groupId>
<artifactId>disruptor</artifactId>

> shoud package disruptor(com.lmax) to flink lib for aync logger when 
> xxconnector using it.
> -----------------------------------------------------------------------------------------
>
>                 Key: FLINK-29227
>                 URL: https://issues.apache.org/jira/browse/FLINK-29227
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.17.0
>            Reporter: jackylau
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.17.0
>
>
> when i develop xxConnector which dependecncy like this
>       xxconnector -> log4j2 -> AsyncLoggerConfig (jar: disruptor(com.lmax))
> xconnector loaded by user(childFirst) classloader
> log4j2 which loaded by app classloader, which also make AsyncLoggerConfig 
> loaded by app classloader, according to the principle of classloader. and the 
> flink lib don't have disruptor, which cause ClassNotFound. Although, the 
> disruptor jar exists in my xxconnector
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to