bzhaoopenstack commented on code in PR #20642:
URL: https://github.com/apache/flink/pull/20642#discussion_r964728414
##########
flink-dist/pom.xml:
##########
@@ -715,6 +715,8 @@ under the License.
<artifact>*</artifact>
<excludes>
<exclude>org/apache/flink/runtime/util/bash/BashJavaUtils.class</exclude>
+
<exclude>io/fabric8/**</exclude>
Review Comment:
The files of `io.fabric8` directory are `zjsonpatch` and `kubernetes`.
I think I agree with you before I add this exclude option. But when I
removed this line in pom from flink-dist and package the whole project in my
env. The `io.fabric8` actually is packaged into the flink-dist.jar . The same
behavior with the following line for "META-INF/services"(it will contain the
shaded service file and non-shaded ones). If we remove both lines in flink-dist
pom, the packaged flink-dist.jar will contain `io.fabric8` and
`org.apache.flink.kubernetes.shaded.io.fabric8`, which contains the same class
files. But the flink-kubernetes will package as wish. So I think the behavior
might be related with the shade of flink-dist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
