afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r963653708
########## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GeneratorSourceReaderFactory.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.connector.source.lib.util; + +import org.apache.flink.api.connector.source.SourceReader; +import org.apache.flink.api.connector.source.SourceReaderContext; +import org.apache.flink.api.connector.source.lib.GeneratorFunction; +import org.apache.flink.api.connector.source.lib.NumberSequenceSource; +import org.apache.flink.api.connector.source.lib.SourceReaderFactory; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A factory for instantiating source readers that produce elements by applying a user-supplied + * {@link GeneratorFunction}. This implementation also implicitly supports throttling the data rate + * by using a default rate limiter. + * + * @param <OUT> The type of the output elements. + */ +public class GeneratorSourceReaderFactory<OUT> + implements SourceReaderFactory<OUT, NumberSequenceSource.NumberSequenceSplit> { + + private final GeneratorFunction<Long, OUT> generatorFunction; + private final double sourceRatePerSecond; + + /** + * Instantiates a new {@code GeneratorSourceReaderFactory}. + * + * @param generatorFunction The generator function. + * @param sourceRatePerSecond The target source rate per second. This parameter specifies the + * overall source rate (across all source subtasks) and does not need to account for the + * parallelism. Review Comment: > I don't quite get what does not need to account for the parallelism is meant to convey. I wanted to underline the fact that this is really the overall rate and not the rate per source reader. Otherwise the user would have been expected to adjust this value together with the changes of the job parallelism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
