afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r963528295
########## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GuavaRateLimiter.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.connector.source.lib.util; + +import org.apache.flink.shaded.guava30.com.google.common.util.concurrent.RateLimiter; + +/** An implementation of {@link RateLimiter} based on Guava's RateLimiter. */ +public class GuavaRateLimiter Review Comment: `GuavaFlinkConnectorRateLimiter` depends on the `RuntimeContext`, which we do not expose in the new Source interface model, so unifying them won't work. `FlinkConnectorRateLimiter` is only used in the `PubSubSource`, which is based on the old source interfaces, has to be rewritten, and will probably be externalized out of the main Flink project. I think we should consider those old rate-limiting interfaces as deprecated. ########## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/GuavaRateLimiter.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.connector.source.lib.util; + +import org.apache.flink.shaded.guava30.com.google.common.util.concurrent.RateLimiter; + +/** An implementation of {@link RateLimiter} based on Guava's RateLimiter. */ +public class GuavaRateLimiter Review Comment: `GuavaFlinkConnectorRateLimiter` depends on the `RuntimeContext`, which we do not expose in the new Source interface model, so unifying them won't work. `FlinkConnectorRateLimiter` is only used in the `PubSubSource`, which is based on the old source interfaces, has to be rewritten, and will probably be externalized out of the main Flink project. I think we should consider those old rate-limiting interfaces as being deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
