snuyanzin commented on code in PR #19916: URL: https://github.com/apache/flink/pull/19916#discussion_r963123365
########## flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java: ########## @@ -46,15 +47,15 @@ import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.assertj.core.api.Assertions.fail; import static org.mockito.Mockito.mock; -import static org.powermock.api.mockito.PowerMockito.when; +import static org.mockito.Mockito.when; Review Comment: There are probably 2 major things which from my point of view could be the reason to avoid it 1. PowerMock does not support JUnit5 https://github.com/powermock/powermock/issues/1053 2. PowerMock does not support JDK17 https://github.com/powermock/powermock/issues/1094 3. There is no any activity to fix any of this two .... for several years Regarding `PowerMockito#when` under the hood it uses the same `Mockito` e.g. https://github.com/powermock/powermock/blob/release/2.x/powermock-api/powermock-api-mockito2/src/main/java/org/powermock/api/mockito/PowerMockito.java#L416-L423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
