mxm commented on code in PR #20485:
URL: https://github.com/apache/flink/pull/20485#discussion_r963030325
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherTest.java:
##########
@@ -255,6 +256,23 @@ public void testClose() {
assertThat(splitReader.isClosed()).isTrue();
}
+ @Test
+ public void testCloseAfterPause() {
+ final FutureCompletingBlockingQueue<RecordsWithSplitIds<Object>> queue
=
+ new FutureCompletingBlockingQueue<>();
+ final SplitFetcher<Object, TestingSourceSplit> fetcher =
+ createFetcherWithSplit(
+ "test-split",
+ queue,
+ new
TestingSplitReader<>(finishedSplitFetch("test-split")));
+
+ fetcher.pause();
+
+ new Thread(fetcher::shutdown).start();
+
+ fetcher.runOnce();
Review Comment:
Done.
##########
flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java:
##########
@@ -282,4 +282,21 @@ public enum VertexDescriptionMode {
.withDescription(
"Whether name of vertex includes topological index
or not. "
+ "When it is true, the name will have a
prefix of index of the vertex, like '[vertex-0]Source: source'. It is false by
default");
+
+ @PublicEvolving
+ public static final ConfigOption<Boolean> ALLOW_UNALIGNED_SOURCE_SPLITS =
Review Comment:
Deprecated doesn't allow for a string as argument but I've added an
additional comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
