SteNicholas commented on code in PR #286:
URL: https://github.com/apache/flink-table-store/pull/286#discussion_r962933579
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/ValueCountMergeFunction.java:
##########
@@ -41,8 +43,11 @@ public void reset() {
}
@Override
- public void add(RowData value) {
- total += count(value);
+ public void add(KeyValue kv) {
+ checkArgument(
+ kv.valueKind() == RowKind.INSERT,
+ "In value count mode, only insert records coming. This is a
bug. Please file an issue.");
Review Comment:
```suggestion
"In value count mode, only insert records come. This is a
bug. Please file an issue.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
