[ 
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506441#comment-15506441
 ] 

ASF GitHub Bot commented on FLINK-4564:
---------------------------------------

Github user ex00 commented on the issue:

    https://github.com/apache/flink/pull/2517
  
    Thanks zentol!
    
    > Something i thought of was to create a "front" metric group for every 
reporter that is aware of this index. 
    
    Do you mean new MetricGroup implementation with name like 
FrontTaskManagerMetricGroup for example? Or what do you mean by "front" metric 
group?
    
    > As a general remark, we strongly encourage people to first discuss their 
implementation in the JIRA instead of going ahead with a PR.
    
    I am novice in community. In future I will know. Thanks.


> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
>                 Key: FLINK-4564
>                 URL: https://issues.apache.org/jira/browse/FLINK-4564
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>
> Currently, the delimiter used or the scope string is based on a configuration 
> setting shared by all reporters. However, different reporters may have 
> different requirements in regards to the delimiter, as such we should allow 
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no 
> specific setting was set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to