[GitHub] [flink] xuyangzhong commented on a diff in pull request #20705: [FLINK-29113][table-planner] throw exception when finding at least one invalid table name in join hints

[GitBox]

xuyangzhong commented on code in PR #20705:
URL: https://github.com/apache/flink/pull/20705#discussion_r961408991


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/JoinHintResolver.java:
##########
@@ -99,10 +105,14 @@ private RelNode visitBiRel(BiRel biRel) {
                 assert null != lookupTable;
                 if (rightName.isPresent() && matchIdentifier(lookupTable, 
rightName.get())) {
                     validHints.add(trimInheritPath(hint));
+                    updateInfoForOptionCheck(hint.hintName, leftName);

Review Comment:
   Actually, there is no need to check multi table name for lookup join because 
there only is one table for lookup join hint. So I delete this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org