JingsongLi commented on code in PR #281:
URL: https://github.com/apache/flink-table-store/pull/281#discussion_r960178500
##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/file/predicate/PredicateConverter.java:
##########
@@ -91,15 +91,17 @@ public Predicate visit(CallExpression call) {
for (int i = 1; i < children.size(); i++) {
literals.add(extractLiteral(fieldRefExpr.getOutputDataType(),
children.get(i)));
}
- return builder.in(fieldRefExpr.getInputIndex(), literals);
+ return builder.in(builder.indexOf(fieldRefExpr.getName()),
literals);
Review Comment:
It is safer to use name. The previous implementation has problems, because
if the project pushdown is before and the filter pushdown is after, the index
of the filter will be projected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
