Github user lw-lin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2515#discussion_r79544108
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegment.java ---
    @@ -161,7 +161,7 @@
                }
                if (offHeapAddress >= Long.MAX_VALUE - Integer.MAX_VALUE) {
                        // this is necessary to make sure the collapsed checks 
are safe against numeric overflows
    -                   throw new IllegalArgumentException("Segment initialized 
with too large address: " + address
    --- End diff --
    
    here `address` has not been initialized yet; should really be 
`offHeapAddress`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to