[ 
https://issues.apache.org/jira/browse/FLINK-28940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597069#comment-17597069
 ] 

Zhu Zhu commented on FLINK-28940:
---------------------------------

I have tested it and it looks good to me.
I used sql client to do the test, by connecting it to Hive. By running testing 
jobs, I can see that DPP is taking effect: the topology is modified to have a 
{{DynamicFilteringDataCollector}} and {{Order-Enforcer}}. By comparing the 
number of input records of the join operator, I can see that expected number of 
records are  truely filtered out in ahead. The job result is also as expected.


> Release Testing: Verify FLIP-248 Dynamic Partition Prunning
> -----------------------------------------------------------
>
>                 Key: FLINK-28940
>                 URL: https://issues.apache.org/jira/browse/FLINK-28940
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / Planner, Table SQL / Runtime
>    Affects Versions: 1.16.0
>            Reporter: godfrey he
>            Assignee: Zhu Zhu
>            Priority: Blocker
>              Labels: release-testing
>             Fix For: 1.16.0
>
>
> This issue aims to verify FLIP-248: 
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-248%3A+Introduce+dynamic+partition+pruning
> We can verify it in SQL client after we build the flink-dist package.
> 1. create a partition table and a non-partition table (only hive connector is 
> supported now, or we need write a new collector), and then insert some data
> 2. show the explain result for a join query, whose one side contains a 
> partition table and other side is non-partition table with a filter, such as 
> the example in the FLIP doc: select * from store_returns, date_dim where 
> sr_returned_date_sk = d_date_sk and d_year = 2000. The explain result should 
> contain `DynamicFilteringDataCollector` node.  We can also verify plan for 
> the various variants of above query.
> 3. execute the above plan and verify the execution result. (the execution 
> result should be same with the execution plan which disable dynamic filtering 
> via table.optimizer.dynamic-filtering.enabled)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to