[
https://issues.apache.org/jira/browse/FLINK-28968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585190#comment-17585190
]
lincoln lee commented on FLINK-28968:
-------------------------------------
thanks [~xuyangzhong] for testing this!
> 1. Currently, only connector HBase support async lookup join(and it must add
> the argument "lookup.async"). So I think it's better to note it in doc.
I checked the doc of hbase connector, the 'lookup.async' parameter is not
conspicuous enough
([https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/hbase/#lookup-async),]
and It is not appropriate to specify the hbase connector params directly in
the hint documentation. But as a followup work of FLIP-234, we plan to
deprecate it later (in FLINK-29111)
> 2. Would we better print the lookup join hint on the node `Correlate` in the
> origin RelNode tree? It can help the user to understand the behavior that the
> 'async' is missing in the Optimized RelNode tree because of planner ignores
> it when optimizing.
good idea! it'll be more clear for user debuging, this will be done in
FLINK-29112
thanks again!
> Release Testing: Verify FLIP-234 LOOKUP Hint
> --------------------------------------------
>
> Key: FLINK-28968
> URL: https://issues.apache.org/jira/browse/FLINK-28968
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: lincoln lee
> Assignee: xuyang
> Priority: Blocker
> Labels: release-testing
> Fix For: 1.16.0
>
>
> the user doc draft: [https://github.com/apache/flink/pull/20577]
> The LOOKUP hint allows users to suggest the Flink optimizer to:
> 1. use synchronous(sync) or asynchronous(async) lookup function
> 2. configure the async parameters
> 3. enable delayed retry strategy for lookup
> we can verify each one and also some combinations of above features
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
