morhidi commented on code in PR #351:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/351#discussion_r955084321
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -122,16 +123,23 @@ public final void reconcile(CR cr, Context<?> ctx) throws
Exception {
cr.getStatus().getReconciliationStatus().deserializeLastReconciledSpec();
SPEC currentDeploySpec = cr.getSpec();
+ var specDiff = currentDeploySpec.diff(lastReconciledSpec);
+
+ var flinkService = getFlinkService(cr, ctx);
+
boolean specChanged =
- reconciliationStatus.getState() ==
ReconciliationState.UPGRADING
- || !currentDeploySpec.equals(lastReconciledSpec);
+ DiffType.IGNORE != specDiff.getType()
+ || reconciliationStatus.getState() ==
ReconciliationState.UPGRADING;
+
var observeConfig = getObserveConfig(cr, ctx);
- var flinkService = getFlinkService(cr, ctx);
+
if (specChanged) {
+
if (checkNewSpecAlreadyDeployed(cr, deployConfig)) {
return;
}
- LOG.info(MSG_SPEC_CHANGED);
+ LOG.info(String.format(MSG_SPEC_CHANGED, specDiff.getType()));
+ LOG.info(specDiff.toString());
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
